refactor: Move core providers, services, and platform utilities #559
Conversation
- Move assign_ip/ folder from lib/core/jnap/providers/ to lib/core/utils/ - Move ip_getter/ folder from lib/core/jnap/providers/ to lib/core/utils/ - Update import paths in all affected files (8 files) - Remove unused mock_firmware_update_provider.dart from lib/
- Create new lib/core/data/ directory structure with providers/ and services/ subdirectories - Move dashboard_manager_provider/state from lib/core/jnap/providers/ to lib/core/data/providers/ - Move device_manager_provider/state from lib/core/jnap/providers/ to lib/core/data/providers/ - Move firmware_update_provider/state from lib/core/jnap/providers/ to lib/core/data/providers/ - Move polling_provider from lib/core/jnap/providers/ to lib/core/data/providers/ - Move side_effect_provider from lib/core/jnap/providers/ to lib/core/data/providers/ - Move node_wan_status_provider to lib/core/data/providers/node_internet_status_provider.dart - Move dashboard_manager_service from lib/core/jnap/services/ to lib/core/data/services/ - Move device_manager_service from lib/core/jnap/services/ to lib/core/data/services/ - Move firmware_update_service from lib/core/jnap/services/ to lib/core/data/services/ - Move polling_service from lib/core/jnap/services/ to lib/core/data/services/ - Update all import paths in lib/ and test/ directories - Remove empty lib/core/jnap/providers/ and lib/core/jnap/services/ directories
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
AustinChangLinksys
left a comment
AustinChangLinksys
left a comment
There was a problem hiding this comment.
looks good to me
User description
Summary
lib/core/data/for better organizationlib/core/utils/to centralize platform-specific codeChanges
lib/core/data/lib/core/utils/PR Type
Enhancement
Description
Move core providers and services to
lib/core/data/directory structureMove platform utilities (
assign_ip,ip_getter) tolib/core/utils/Move
node_light_settingsandwan_externalproviders to feature-specific locationsUpdate all import paths across 100+ files in lib/ and test/ directories
Remove unused mock firmware update provider and empty directories
Diagram Walkthrough
File Walkthrough
74 files
Update imports to new data provider locationUpdate imports to new data provider locationUpdate imports to new data provider locationUpdate imports to new data provider locationUpdate imports and move node_light_settings referenceUpdate location comment and polling provider importUpdate imports to new data service locationUpdate imports to new data service locationUpdate imports to new data service locationUpdate imports for providers and utilitiesUpdate side effect provider import pathUpdate device manager state import pathUpdate side effect provider import pathUpdate polling provider import pathUpdate provider imports to new locationsUpdate assign_ip utility import pathUpdate provider imports to new locationsUpdate side effect provider import pathUpdate device manager state import pathUpdate assign_ip utility import pathUpdate provider imports to new locationsUpdate polling provider import pathUpdate device manager provider import pathUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate provider imports and rename node_wan_statusUpdate provider imports and rename node_wan_statusUpdate provider imports and rename node_wan_statusUpdate provider imports and rename node_wan_statusMove node_light_settings to feature locationUpdate polling provider import pathUpdate provider imports and assign_ip utilityUpdate polling provider import pathUpdate provider imports to new locationsUpdate device manager state import pathUpdate firmware update provider import pathUpdate device manager state import pathUpdate device manager state import pathUpdate polling provider import pathUpdate provider imports and ip_getter utilityUpdate polling provider import pathUpdate polling provider import pathUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate device manager state import pathUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate device manager provider import pathUpdate provider imports to new locationsUpdate device manager state import pathUpdate polling provider import pathUpdate firmware update provider import pathUpdate provider imports to new locationsUpdate provider imports to new locationsUpdate device manager state import pathUpdate provider imports to new locationsMove wan_external provider to feature locationMove wan_external provider to feature locationUpdate provider imports to new locationsUpdate provider imports and move wan_externalUpdate provider imports to new locationsUpdate firmware update provider import pathUpdate dashboard manager provider import pathUpdate provider imports to new locationsUpdate device manager state import pathUpdate provider imports to new locationsUpdate device manager state import pathUpdate provider imports to new locationsMove node_light_settings provider to feature locationUpdate device manager state import pathUpdate device manager state import pathUpdate provider imports and move node_light_settings1 files
Remove unused mock firmware update provider file80 files